envoyproxy/envoy

move redis to TCP connection pool

Open

#3,818 opened on Jul 9, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/redishelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Tracking ticket for follow-on modifications related to the generic TCP connection pool, per discussion in #3747:

  • refactor HTTP1 connection pool to extend it
  • modify tcp_proxy to use connection pool vs. tcpConnForCluster
  • modify redis_proxy to use connection pool

Other possible lines of inquiry:

Contributor guide

Research direction
Examine the refactoring of the HTTP1 connection pool in PR #3747 and the tcp proxy modification in #3938. Then, apply the same pattern to redis proxy by replacing its direct TCP connection creation with the generic connection pool.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30