envoyproxy/envoy

Refactor ext_proc client code to remove dynamic_cast

Open

#37,904 opened on Jan 7, 2025

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/ext_prochelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Refactor ext_proc client code to remove dynamic_cast

Description:

Remove this dynamic_cast here:

https://github.com/envoyproxy/envoy/blob/29428f956761918e7112183af50f969b099196f1/source/extensions/filters/http/ext_proc/client_impl.cc#L30

For more details please check: https://github.com/envoyproxy/envoy/pull/35740#discussion_r1781527990

Contributor guide

Research direction
Inspect the linked PR discussion and the code at the specified line to understand the rationale and alternative to dynamic cast. Consider using a base class interface or std::visit pattern.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75