envoyproxy/envoy

Load reporting service missing information UpstreamEndpointStats and NodeID

Open

#35,288 opened on Jul 19, 2024

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (27,997 stars) (5,373 forks)batch import
area/load reportinghelp wanted

Description

The load reporting service example here is not working as expected according to the documentation.

There are many discrepancies between the result show in doc and the result running in sandbox. Following are the details:

  • UpstreamEndpointStats Missing One of the most useful information from load reporting service is UpstreamEndpointStats. According to the example code at lrs_server.go line 63, we enabled this and Envoy should return the data. However, the data is not provided based on my test. (Conducted multiple tests on this and all failed.)

  • ClusterName and NodeID Missing As the example documentation shows, we should have information on ClusterName and NodeID. lrs_server_1 | 2020/02/12 17:09:07 Got stats from cluster http_servicenode0022a319e1e2 - cluster_name:"local_service" upstream_locality_stats:<locality:<> total_successful_requests:21 total_issued_requests:21 > load_report_interval:<seconds:1 nanos:998411000 > Following are the result based on test:

    • Node ID missing: lrs_server-1 | 2024/07/19 23:16:08 Adding new new node to cache ''
    • Cluster information missing

image

Thanks

Contributor guide

Tech stack
gocpp
Domain
backenddocumentation
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Envoy load reportingGoDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the load reporting service example at examples/load reporting service. Compare the expected output in the documentation with actual output. Possible causes include an outdated example or configuration mismatch. Check the server code at server/lrs server.go and the Envoy configuration. Also review comments in the issue for additional context. No PRs are linked.