envoyproxy/envoy

health check filter: cache response body

Open

#3,525 opened on Jun 1, 2018

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently the health check filter only caches the status code of health checks. It would be nice to be able to cache the entire response body to allow other clients that might care about the body go through envoy and the health checking filter.

Contributor guide

Research direction
Look at the existing health check filter's caching mechanism for status code. Extend it to cache the response body by reading from the stream and storing it in the cache entry. Consider response body size and memory management. Also, check if there are any existing tests for the health check filter to understand the expected behavior.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy filter development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40