envoyproxy/envoy

router check tool: configure runtime flags

Open

#35,174 opened on Jul 12, 2024

View on GitHub
 (2 comments) (1 reaction) (0 assignees)C++ (5,373 forks)batch import
area/route_check_toolenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Load runtime flags in router check tool

Description:

We should be able to configure the router check tool with runtime flags as it can influence routing decision/validation.

Use case:

My goal is to make the tool useful with Istio configuration, Istio uses some runtime flags which if not set limits the use of router check tool quite a bit, especially as we have large regex matching routes and the default value of re2.max_program_size.error_level is 100.

My ugly workaround is patching the tool overriding this runtime for my use case.

I see other issues (https://github.com/envoyproxy/envoy/issues/12393, https://github.com/envoyproxy/envoy/issues/13065) that would also benefit from reading the whole envoy configuration instead of just http routes. Would this be the way to go?

Contributor guide

Research direction
Implement the ability to configure runtime flags in the router check tool, following the pattern of other runtime flag configurations in Envoy.
Tech stack
cpp
Domain
backendinfrastructurenetworking
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70