envoyproxy/envoy

Add error handling support to decompressors

Open

#32,621 opened on Feb 28, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/compressionhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Add Error Handling Support to Decompressors

Description: Our filter code utilizes Decompression extensions (Brotli and Zlib) to decode compressed data. Currently, the decompression interface updates its internal statistics when decompression fails, but it does not provide any indication of error to the caller.

This feature request proposes that the decompress method either returns an error directly or that an API is added to retrieve the error from the last decompression call.

Reference: GitHub - envoyproxy/envoy

Contributor guide

Research direction
Examine the decompressor interface in envoy/compression/decompressor/decompressor.h and modify the decompress method to return an error or add an API to retrieve the last error.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55