envoyproxy/envoy

accesslog: expose all fields in FileAccessLogger in data.accesslog.v3.AccessLog for ALS

Open

#31,636 opened on Jan 4, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/access_logenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: expose all fields in FileAccessLogger into data.accesslog.v3.AccessLog for ALS

Description:

There are multiple fields availiable in FileAccessLogger, but some of them were not exposed in ALS, considering ALS have better performance compare with FileAccessLogger to collect access logs, expose those fields in ALS is what needed.

e.g. DOWNSTREAM_PEER_ISSUER, UPSTREAM_PEER_CERT, DOWNSTREAM_PEER_FINGERPRINT_256, DOWNSTREAM_PEER_FINGERPRINT_1, DOWNSTREAM_PEER_SERIAL, DOWNSTREAM_HANDSHAKE_DURATION etc...

Contributor guide

Research direction
Review the FileAccessLogger source and the AccessLog proto, then add missing fields and implement population.
Tech stack
cpp
Domain
backendobservability
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++Protocol Buffers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65