envoyproxy/envoy

Api: Move geoip_headers_to_add from provider level to geoip filter

Open

#31,001 opened on Nov 21, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/geoiparea/http_filterenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Move geoip_headers_to_add from provider level to geoip filter

Description: Currently geoip_headers_to_add are configured in geoip provider. From logical standpoint it makes more sense to have them in geoip filter config instead, as this is not property of provider (from which source the data is being looked up) but filter (what kind of data to get from provider).

Relevant Links Discussion in past PR

Contributor guide

Research direction
Identify the current location of geoip headers to add in the provider proto and filter config. Move the field definition to the filter proto, update the filter implementation to read from the new location, and ensure backward compatibility or migration plan.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++Protobuf
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30