envoyproxy/envoy

Support for Request MetadataKind in InternalUpstreamTransport

Open

#30,674 opened on Nov 2, 2023

View on GitHub
 (5 comments) (1 reaction) (0 assignees)C++ (5,373 forks)batch import
area/listenerenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Support for Request MetadataKind in InternalUpstreamTransport

Description:

I have a usecase where I am extracting an http header in a Lua filter, setting it in dynamicMetadata and passing it to an internal listener which has a TCPProxy filter configured with tunneling_config. The value that is set in dynamicMetadata needs to be referenced in the tunneling_config.

It seems there is support for passthrough_metadata for passing information from one listener to the other listener in this case. However, even though the docs seem to suggest that request metadataKind is supported ( which is needed for passing DynamicMetadata ), it seems the internal implementation is missing here and here

Is my understanding correct ? Happy to work on a PR if I can get any pointers!

[optional Relevant Links:]

Any extra documentation required to understand the issue.

Contributor guide

Research direction
Examine the InternalUpstreamTransport config.cc file and add support for Request metadata kind by extending the existing loop to handle it similarly to Connection metadata kind.
Tech stack
cpplua
Domain
backendinfrastructurenetworking
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40