envoyproxy/envoy

access_log: support for logging route/listener/cluster metadata

Open

#3,006 opened on Apr 5, 2018

View on GitHub
 (12 comments) (1 reaction) (1 assignee)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: access_log: support for logging route/listener/cluster metadata

Description: Suggest by @htuch during review of implementation of access log support for dynamic metadata (#2895) . There are cases that logging route/listener/cluster metadata can come useful such as multitenant environments.

Contributor guide

Research direction
Study the existing dynamic metadata access log support (PR #2895). Then extend the AccessLog::Instance interface to allow logging of route, listener, and cluster metadata by accessing their metadata stores. Look at how metadata is stored and retrieved in Envoy's Route, Listener, and Cluster objects. Implement the necessary changes in the access log formatter and filters.
Tech stack
cpp
Domain
backendobservability
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60