envoyproxy/envoy

ext_proc: knob to disallow immediate_response

Open

#28,698 opened on Jul 28, 2023

View on GitHub
 (8 comments) (0 reactions) (2 assignees)C++ (5,373 forks)batch import
area/ext_procenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: ext_proc: knob to disallow immediate_response

Description: Just like the way we have a knob disallow_clear_route_cache that will ignore a clear_route_cache setting in the ProcessingResponse, we need a knob on the filter (disallow_immediate_response) that will ignore an immediate_response value in the ProcessingResponse. The behavior should be to close the ext_proc stream but NOT do the immediate response. Instead, the request should be forwarded as through no changes were done by ext_proc.

Knob is false by default.

Contributor guide

Research direction
Examine the existing `disallow clear route cache` implementation and replicate its pattern for `immediate response`. Look at how the knob is defined in configuration, how it's checked in the filter's processing logic, and how the stream is closed without performing the immediate response.
Tech stack
cpp
Domain
infrastructureapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50