envoyproxy/envoy

Remove tokens from the default bucket only if there is no matching descriptor.

Open

#28,469 opened on Jul 18, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/ratelimithelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Remove tokens from the default bucket only if there is no matching descriptor.

Description: I have a question about the Local RateLimit plugin. In version 1.23.0, the local_ratelimit started removing tokens from all matching buckets, including the default bucket, which now always has a token removed. Is there a way to prevent this from happening, removing tokens from the default only if there is no matching descriptor?

If there is no way to do this currently, could we make it parameterizable?

Thank you in advance.

[optional Relevant Links:] https://github.com/envoyproxy/envoy/pull/20869

Contributor guide

Research direction
Review the linked PR #20869 to understand the current token bucket behavior and explore how to add a parameter to control token removal from the default bucket only when no descriptor matches.
Tech stack
ccpp
Domain
backendinfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Envoy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30