envoyproxy/envoy

Allow removing some of the default tags from zipkin traces

Open

#27,614 opened on May 24, 2023

View on GitHub
 (1 comment) (1 reaction) (0 assignees)C++ (5,373 forks)batch import
area/tracingenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

The zipkin traces generated by envoy by default have a lot of tags and tags like response_size, request_size which can really bloat and load the trace backend. Some of these tags should really be logs.

Is there any way to configure envoy to not add some of these tags by default on the spans? i.e. some way to define a minimal set of tags which envoy should be attaching to each span. I couldn't find anything in here: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/observability/tracing

Contributor guide

Research direction
Examine the Zipkin tracer implementation in Envoy to find where default span tags are added. Then implement a configuration option to specify a list of tags to exclude. The configuration should be parsed from the YAML config and applied when creating spans.
Tech stack
cpp
Domain
networkingobservability sre
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++BazelGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60