envoyproxy/envoy

fault Injection response_rate_limit issue

Open

#26,479 opened on Mar 31, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/ratelimitenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Fault Injection config options response_rate_limit currently only simple speed limits are supported. Can support speed limits after the body response fixed size? For example, Nginx limit_rate_after options.

Contributor guide

Research direction
Study the existing fault injection filter code in Envoy, specifically the response rate limit implementation. Understand how speed limits are applied and identify where to add an option for a body size threshold before applying the rate limit, similar to Nginx's limit rate after. Implement the new config field and integrate it into the rate limiting logic.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy architectureFault injection concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40