envoyproxy/envoy

Upstream Access Log can be incorrect if upstream stream outlives downstream

Open

#26,413 opened on Mar 28, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/access_logarea/httpbughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Access Log: Can be incorrect if upstream stream outlives downstream

Description:

What issue is being seen? Describe what should be happening instead of the bug, for example: Envoy should not crash, the expected value isn't returned, etc.

As demonstrated by https://github.com/envoyproxy/envoy/pull/26196/files#diff-478cdae3dba52e78ed6d1a2e4e4eb4a1aba3e80178b6c8d14707501fc1fb2ddbR3413-R3498

There are some edge scenarios where the upstream access logs will not reflect the actuality of the upstream stream due to when the access logs are captured -- on downstream stream destruction.

Contributor guide

Research direction
Investigate the access log capture timing relative to upstream and downstream stream lifetimes. Examine the PR referenced (https://github.com/envoyproxy/envoy/pull/26196/files#diff 478cdae3dba52e78ed6d1a2e4e4eb4a1aba3e80178b6c8d14707501fc1fb2ddbR3413 R3498) to understand the edge case and propose a fix that ensures access logs reflect actual upstream stream state even when upstream stream outlives downstream.
Tech stack
cpp
Domain
backendinfrastructurenetworking
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Envoy internalsaccess logging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40