envoyproxy/envoy

`schema_validator_tool` should not be `testonly`

Open

#26,390 opened on Mar 28, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/releasearea/schema_validatorbughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Currently the schema_validator_tool is built using envoy_cc_test which marks it testonly and it in turn depends on a bunch of test libs that are likewise testonly

this should not be the case given that this tool is published, and means that it cannot be depended upon as a build target by other non-test build targets

i made an inexpert attempt at doing this, but found myself copying out increasingly large chunks of the test framework. I gave up when i needed to start copying out the test thread code

Contributor guide

Research direction
Modify the build rules for schema validator tool to not use envoy cc test, and instead use a non testonly rule, while refactoring dependencies to avoid testonly dependencies.
Tech stack
cpp
Domain
backendbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Bazel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40