envoyproxy/envoy

Are the lb_policy and lb_config forced to match?

Open

#25,583 opened on Feb 15, 2023

View on GitHub
 (9 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/configurationarea/load balancinghelp wantedquestion

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Description: Currently in clusterInfoImpl when the lb_configs are loaded, it doesn't check if the lb_policy matches the config that's loaded. We have a separate member for the lb_policy and other members for each config type. Is there anything to stop the user from setting a round_robin config but also setting the lb_policy to least request? If there isn't, should anything be done about that?

Relevant Links: Current implementation of how the lb config members are initialized

Current location of where lb_policy is set

Contributor guide

Research direction
Inspect the current implementation in source/common/upstream/upstream impl.cc to see if there is any validation that ensures lb policy matches the provided lb config. If not, consider adding a check in the cluster initialization to warn or error when mismatch occurs. Look at how other similar config mismatches are handled in the codebase.
Tech stack
cpp
Domain
backend
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++understanding of Envoy configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70