envoyproxy/envoy

Align Windows getaddrinfo behavior to other platforms

Open

#24,326 opened on Dec 2, 2022

View on GitHub
 (9 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/windowsbughelp wantedno stalebot

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Align Windows getaddrinfo behavior to other platforms

Description: #23957 shows how Windows parsing is more relaxed compared to other platforms. We may want to align it to have the same strictness in order to have a consistent behavior.

Repro steps: Remove the compiler ifndef directive introduce in #23957 and run: ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.dev //test/common/network:utility_test --test_output=all'

Contributor guide

Research direction
Investigate the ifndef directive introduced in PR #23957 and understand how Windows getaddrinfo parsing differs from other platforms. Test by removing the directive and running the specified bazel test to see failures.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Bazel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40