envoyproxy/envoy

test framework: set default concurrency, and make concurrency an explicit option in integration test framework

Open

#24,246 opened on Nov 29, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: test framework: set default concurrency, and make concurrency an explicit option in integration test framework

Description: Envoy by default starts a worker for every hardware thread, https://blog.envoyproxy.io/envoy-threading-model-a8d44b922310

for tests run on a beefy machine, this usually means either 64/72 or even 128 workers are started in an integration test.

I am not sure so many workers are desired, which may even cause noise in test. I think we should make it an explicit option to let each integration test to pick how many workers are started, and set the default to 1 or 2 if multiple workers are not desired for the test.

Contributor guide

Research direction
Investigate current concurrency settings in the integration test framework, then add an option to configure concurrency and set default to 1 or 2.
Tech stack
cpp
Domain
backendtesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy integration test framework
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40