envoyproxy/envoy

redis outlier detection when redis is down but Envoy is up

Open

#24,215 opened on Nov 26, 2022

View on GitHub
 (12 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/outlier_detectionarea/redishelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

In the current implementation , when server Envoy is up but redis down, we send proper error response with "UpstreamFailure" - as a result of the this Client Envoy does not detect this as outlier and eject even when outlier detection is enabled on client side.

So in cases where redis container is down but Envoy is up - Should n't this failure treated as outlier from client side (similar to 503 in http)?

Or are there any reasons why this has been implemented like this?

Contributor guide

Research direction
Examine the Redis filter outlier detection code in Envoy to understand why upstream failures are not treated as outliers, and propose a fix to treat Redis down as an outlier event.
Tech stack
None
Domain
backendinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitEnvoy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60