envoyproxy/envoy

Envoy should NACK an EDS update with duplicate addresses

Open

#23,445 opened on Oct 11, 2022

View on GitHub
 (2 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/edsbughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Currently, if there are multiple addresses in the same EDS resource, Envoy will ignore all but the first occurrance. This behavior seems fairly arbitrary and surprising, especially because the different occurrances of the address could be in different localities or priorities.

I think in this case, Envoy should NACK the EDS update.

CC @kyessenov

Contributor guide

Research direction
Investigate the EDS update handling code in envoy/source/common/upstream/eds.cc, specifically the logic that ignores duplicate addresses. Trace the path from EDS response parsing to NACK generation. Understand the validation framework and how to reject an update with duplicate addresses by triggering a NACK.
Tech stack
None
Domain
infrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50