envoyproxy/envoy

presubmit-check the use of DECLARE_FACTORY for each DEFINE_FACTORY

Open

#23,173 opened on Sep 19, 2022

View on GitHubContributor guide
 (3 comments) (1 reaction) (0 assignees)C++ (5,373 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (PR metrics pending)

Description

E-M apparently depends on the former and nothing checks on it upstream :-(

Contributor guide

Research direction
Analyze the existing DEFINE FACTORY and DECLARE FACTORY macros in the codebase. Determine the pattern to ensure each DEFINE FACTORY has a corresponding DECLARE FACTORY. Propose a presubmit check (e.g., using a script or CI job) that scans for violations.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++understanding of Envoy macro system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35