envoyproxy/envoy

AWS request signing filter virtual host-specific config

Open

#21,541 opened on Jun 2, 2022

View on GitHub
 (8 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/awshelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: AWS request signing filter virtual host-specific config

Description:

I have Envoy deployed with a single TLS listener that is using virtual hosts. I need to tell each virtual host to use the typed_per_filter_config to apply the envoy.filters.http.aws_request_signing filter. However, when I apply the filter on the virtual host level, the following error is displayed:

The filter envoy.filters.http.aws_request_signing doesn’t support virtual host-specific configurations

Is there a technical reason this filter cannot be applied to a virtual host config? Technical being either the extension does not implement the correct interface and it just needs to be updated or a deeper technical issue that would cause issues when applied at the virtual host level?

When looking at the AWS Lambda filter, it states it explicitly supports per-filter configuration. I'm assuming that means it could apply at the route/virtual host level?

Also, I looked in the documentation but could not find it… Is there a way to get a list of extensions that are available per-filter config level?

Relevant Links:

Contributor guide

Research direction
Examine the AWS request signing filter source code in the repository to see if it implements the PerFilterConfigFactory interface. Look at the filter factory class and check if it defines `createFilterConfig` or `createPerFilterConfig` methods. Compare with the AWS Lambda filter which supports per filter config. Also review the Envoy documentation on HTTP filter configuration scopes to understand how virtual host specific configs are applied.
Tech stack
cpp
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++Bazel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65