envoyproxy/envoy

Admission Control: support per route config

Open

#21,255 opened on May 11, 2022

View on GitHub
 (12 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/admission_controlhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

QUESTION: Admission Control Non-Global Configurations

Description: When I try to configure Admission Control for a specific route I get the error that The filter envoy.filters.http.admission_control doesn't support virtual host-specific configurations.

I'm trying to understand the limits of this. Could I for example split traffic on headers and apply Admission Control to one set of headers? I'm still getting my bearings in the codebase, but I think this wouldn't be possible, right?

What would the complexity (and interest) be in a patch to make this filter available for virtual host-specific configurations, ex. for different headers, or different subpaths.

Thank you,

Contributor guide

Research direction
Investigate how Envoy filters are configured per virtual host and modify the admission control filter to support per route configuration. Look at existing filter implementations that support per route config as examples.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Envoy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30