envoyproxy/envoy

QUESTION: Static Configuration Failing Validation

Open

#21,221 opened on May 10, 2022

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/docshelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

QUESTION: Static Configuration for Admission Control Failing Validation

Description: I’m trying to write a static configuration file to configure an admission control filter in a testing environment. The sr_threshold and max_rejection_probability fields are the source of errors. The configuration is valid if I comment them out (so that default values are used). It seems the problem is a type issue with v3.Percent for those 2 fields. INVALID_ARGUMENT:(sr_threshold.default_value): invalid value "95.0" for type type.googleapis.com/envoy.type.v3.Percent

What am I doing wrong here? I’ve tried numerous combinations of specifying the typed_config or not, etc, copying patterns from other examples, etc

Thank you!

Contributor guide

Research direction
Review the Envoy type Percent documentation and examples of admission control filter configuration. The error indicates that the value '95.0' is being interpreted as a string, but Percent expects a numeric value between 0 and 1. Check the protobuf definition and ensure the value is between 0 and 1 (e.g., 0.95).
Tech stack
cpp
Domain
api
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
YAMLBasic understanding of Envoy proxy configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75