envoyproxy/envoy

Enforce prevention of multiple instances of a locality in the same priority

Open

#20,768 opened on Apr 11, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
apihelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Enforce prevention of multiple instances of a locality in the same priority

Description: PR #20574 refined the LocalityLbEndpoints structure to be defined as:

// A group of endpoints belonging to a Locality.
// One can have multiple LocalityLbEndpoints for a locality, but only if
// they have different priorities.

but Envoy allows to have multiple LocalityLbEndpoints for a locality if the different groups have different weights or different priorities.

Envoy should be more restrictive, and confirm to the revised comment.

cc @markdroth

Contributor guide

Research direction
Examine the current validation logic for LocalityLbEndpoints in Envoy and add a check to prevent multiple instances of the same locality with the same priority. Review PR #20574 for context.
Tech stack
cpp
Domain
backendnetworking
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60