envoyproxy/envoy

matchers: add firstOf matcher

Open

#20,666 opened on Apr 5, 2022

View on GitHub
 (5 comments) (1 reaction) (1 assignee)C++ (5,373 forks)batch import
area/matchingarea/tlsenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

For something like ALPN list matching, we need a way to say: iterate over the input, which is a list, until the inner matches accepts. The core API does not provision this use case, so this has to be done as a meta-matcher with a custom matcher.

Contributor guide

Research direction
Study existing matchers in the codebase (e.g., in source/common/matcher/) and understand the matcher interface. Then implement a new MetaMatcher that iterates over a list and applies an inner matcher until it matches.
Tech stack
ccpp
Domain
networking
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50