envoyproxy/envoy

Refactor JWT matching logic

Open

#20,578 opened on Mar 30, 2022

View on GitHub
 (7 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/jwt_authnarea/matchingenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

As per https://github.com/envoyproxy/envoy/pull/20145, we have duplicative matching logic in core router and JWT filter. This seems a maintenance, testing and security concern. I think with some modest refactoring, we could move this match logic to a common library. This is a fairly straightforward refactoring I think (famous last words).

Contributor guide

Research direction
Review the JWT matching logic in core router and JWT filter, identify duplication, and refactor into a common library.
Tech stack
cpp
Domain
backendsecurity
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
cpp
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60