envoyproxy/envoy

Add CI to ensure all `CODEOWNERS` are assignable

Open

#20,464 opened on Mar 22, 2022

View on GitHub
 (8 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/cicontribenhancementhelp wantedno stalebot

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

description

Currently not all CODEOWNERS are assignable - which means that when relevant PRs come up we are unable to assign reviews to the relevant people

This issue is being addressed manually but it would be useful to have CI to ensure that this is kept up to date

One implication here is that a senior maintainer will have to sign off (eg by adding assignable to the relevant dev) any new contribs that have new devs listed as codeowners

Contributor guide

Research direction
Investigate how to script a check that verifies all users listed in CODEOWNERS are assignable using GitHub API and add a CI job.
Tech stack
None
Domain
ci cd
Issue type
DevOps
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60