envoyproxy/envoy

Clean up PANIC macros

Open

#19,229 opened on Dec 9, 2021

View on GitHub
 (12 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
beginnerenhancementhelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

https://github.com/envoyproxy/envoy/pull/19204 replaced NOT_REACHED_GCOVR_EXCL_LINE macros with more clear PANIC_DUE_TO_CORRUPT_ENUM macros.

While more clear, the panics are still suboptimal becasue doing break; instead of return; results in production crashes. These should be cleaned up and replaced with sensible defaults on a case by case basis.

Contributor guide

Research direction
Replace each PANIC DUE TO CORRUPT ENUM macro with a sensible default return value instead of break, ensuring production stability.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60