envoyproxy/envoy

quic: do not hard code "h3" APLN in EnvoyQuicProofSource

Open

#18,935 opened on Nov 8, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/quichelp wantedno stalebot

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

QUICHE interfaces in quic::ProofSource doesn't pass around ALPN negotiated by BoringSsl, but Envoy filter chain retrieval uses ALPN as part of the query. Right now, we hard-code h3 as the ALPN when we construct a ConnectionSocket for server session, but we should make the negotiated APLN available from QUICHE, and use it in Envoy glue code.

Contributor guide

Research direction
Investigate how ALPN is negotiated in BoringSSL and passed through QUICHE to Envoy. Modify QUICHE's ProofSource interface to include ALPN, then update Envoy's QUIC integration to use that ALPN instead of hard coding "h3".
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++QUICEnvoy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25