envoyproxy/envoy

[Bandwidth-Limit] Gauge metrics not decrement correctly

Open

#18,703 opened on Oct 21, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/statsbughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: BandwidthLimit Filter Gauge metrics not decrement correctly

Description: The following Gauge metrics are not correctly decremented

  • request_incoming_size
  • request_allowed_size
  • response_incoming_size
  • response_allowed_size

Repro steps:

Include sample requests, environment, etc. All data and inputs required to reproduce the bug.

Refer to PR: https://github.com/envoyproxy/envoy/pull/18267

Contributor guide

Research direction
Examine the linked PR #18267 and the BandwidthLimit filter code to trace the decrement logic for the gauge metrics: request incoming size, request allowed size, response incoming size, response allowed size.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy development setupBasic knowledge of Envoy filters
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40