envoyproxy/envoy

TCP Proxy protocol V2 : store data as base64 string

Open

#18,580 opened on Oct 12, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/proxy_protohelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

If you are reporting any crash or any potential security issue, do not open an issue in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately.

Title: Store TLV data of proxy protocol V2 as base64

Description: Proxy protocol V2 uses binary data for TLV. When using the tcp proxy filter, we are able to store the tlv data in the metadata as a string. Since it's binary, it would be more appropriate to store it as base64. Currently, when we try to log it, we get an error saying it contains invalid characters.

Contributor guide

Research direction
Investigate the proxy protocol V2 TLV handling code in the TCP proxy filter and modify the metadata storage to encode TLV data as base64 string instead of raw binary.
Tech stack
cpp
Domain
backendnetworking
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50