envoyproxy/envoy

Custom headers are not available to the SNI `override_auto_sni_header` when added using `request_headers_to_add`

Open

#18,308 opened on Sep 29, 2021

View on GitHub
 (3 comments) (1 reaction) (0 assignees)C++ (5,373 forks)batch import
area/httparea/tlshelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title

Custom headers are not available to the SNI override_auto_sni_header when added using request_headers_to_add

Description

We now allow a customer header to populate the SNI for the upstream requests [Link]. But, if the custom header is not coming from downstream and gets added anywhere using request_headers_to_add then it's value is not available here as this piece of code to populate the SNI gets invoked before we add/modify the request headers probably here.

Contributor guide

Research direction
Investigate the order of operations in router.cc: specifically, look at lines 517 and 648 to understand the sequence of header addition and SNI population. Determine if moving the SNI population after header addition fixes the issue.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Envoy internalsC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20