envoyproxy/envoy

Migrating `RateLimit` to typed filter config phase 2: Envoy consumes the new field

Open

#18,118 opened on Sep 14, 2021

View on GitHub
 (2 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/ratelimithelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Migrating RateLimit to typed filter config phase 2: Envoy consumes the new field

Description: This is to track the second phase of migrating Ratelimit to RateLimitPerRoute. In the first phase, the field is added to typed filter config. Now this work needs to be completed as described here: https://github.com/envoyproxy/envoy/pull/18044#discussion_r706285153.

Relevant Links:

  • #14732

cc @yanavlasov @tyxia @mattklein123 @markdroth

Contributor guide

Research direction
Study the typed filter config pattern used in Envoy (e.g., TcpProxy, HttpConnectionManager) and understand how to consume the new RateLimitPerRoute field from the existing RateLimit filter config. Review the discussion in PR #18044 and phase 1 changes. Implement the consumption of the new field in the RateLimit filter, ensuring backward compatibility.
Tech stack
c
Domain
backendinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Envoy filter configProtobuf
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30