envoyproxy/envoy

Use admission control per domain/virtual_host

Open

#17,648 opened on Aug 10, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/admission_controlhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Hi folks, I have an outbound listener which routes traffic to different clusters based on domains. For each different cluster, I'd like to apply different admission control configurations (e.g the success criteria). Is it possible to somehow apply this filter to per domain level? Does this filter support typed_per_filter_config? If so, is it going to overwrite the global config or the same filter would be used twice? I'm also wondering if this filter is production ready, since the state on the website is still experimental. https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/admission_control_filter#admission-control Thanks!!

Contributor guide

Research direction
Check Envoy admission control filter documentation for typed per filter config support and per virtualhost configuration. Review source code for filter config merge behavior.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
Envoy proxy configurationHTTP filters
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30