envoyproxy/envoy

Stats: Expose downstream_rq_xx counter with specific response codes

Open

#17,370 opened on Jul 15, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/httphelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Currently, for the downstream response count, we have downstream_rq_1xx, downstream_rq_2xx metrics which are aggregated by the response codes, and thereby there's only the response code class label exposed. It would be good to have these metrics by specific response code along with aggregating them into a response code class.

There is something similar already exposed in case of upstream metrics, would be useful to have the same for downstream ones as well.

Contributor guide

Research direction
Study the implementation of upstream rq xx stats for dynamic HTTP statistics and replicate a similar pattern for downstream stats, exposing per response code counters.
Tech stack
None
Domain
backendinfrastructureobservability
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Envoy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60