envoyproxy/envoy

Install envoy.exe into ProgramData/envoy/bin

Open

#17,232 opened on Jul 5, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/windowshelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Install envoy.exe into ProgramData/envoy/bin

Description: Right now, in the envoy-windows image, envoy.exe installs into Program Files/envoy/envoy.exe

While this does match historic install directories, choosing this makes tooling more difficult as for example make struggles with spaces.

It would be easier to install into ProgramData/envoy/bin/envoy.exe similar to the Chocolatey package manager: ProgramData/chocolately/bin/choko.exe.

Doing so wouldn't be completely unconventional, in other words, and we already write files to this directory, ex. ProgramData/envoy/envoy.yaml

Contributor guide

Research direction
Modify the installer script to install envoy.exe to ProgramData/envoy/bin instead of Program Files/envoy.
Tech stack
None
Domain
backend
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Windows
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70