envoyproxy/envoy

Allow custom values of CMAKE_BUILD_TYPE

Open

#17,106 opened on Jun 23, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/buildenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Allow custom values of CMAKE_BUILD_TYPE

Description: Currently Envoy's build system sets CMAKE_BUILD_TYPE to Bazel unconditionally (since #8280). Yet some CMake-based dependencies modify e.g. defines or CFLAGS for different build types. The conventional values are Debug, Release, RelWithDebInfo etc.

It would be nice for debug purposes (or for enabling optimizations) to override CMAKE_BUILD_TYPE in the envoy_cmake_external() rule.

Contributor guide

Research direction
Find the definition of envoy cmake external() in the Bazel build files and trace how CMAKE BUILD TYPE is set to 'Bazel' unconditionally. Identify where to add a parameter to allow overriding it and understand the existing CMake integration pattern.
Tech stack
cpp
Domain
build system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++CMakeBazel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60