envoyproxy/envoy

Metric for requests with request hedging enabled

Open

#16,351 opened on May 5, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/httparea/statshelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Metric for request hedging

Description: Looking at the source https://github.com/envoyproxy/envoy/blob/3e9b84809fbe78d0dd2c3c2e960aa2519505d251/source/common/router/router.cc#L240-L259 there doesn't appear to be a metric being emitted when request hedging is enabled. I'd like to have one there so I can tell how many requests it's been enabled for.

Contributor guide

Research direction
Examine the router code at the referenced lines and add a stat counter for request hedging, following the existing pattern for metric emission (e.g., using the Stats::Scope). Ensure the counter is labeled appropriately and verify through existing tests.
Tech stack
cpp
Domain
infrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy development setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40