envoyproxy/envoy

rate limit: modularize the extension configuration

Open

#15,633 opened on Mar 23, 2021

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/ratelimithelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Currently, rate limit in envoy requires actions field that is defined in the virtual host and route configuration. This puts a pressure on the control plane to couple core networking configuration with the rate limit configuration (e.g. it's impossible to customize actions with ECDS). The proposal is to move actions into the extension configuration itself.

Contributor guide

Research direction
Understand the current rate limit actions placement in virtual host and route configuration, then design a way to move them into the extension configuration while maintaining backward compatibility.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++EnvoyRate limiting concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35