envoyproxy/envoy

Broken Prefix Route Match

Open

#15,592 opened on Mar 21, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/docsarea/httphelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: Broken Prefix Route Match

Description:

PrefixRouteEntryImpl::matches used to include (as of 1.13.0) query parameter in the match , now it is excluding the query parameter from match due to this change, by this commit, here is previous code.

Documentation has not changed, wonder if this is intended!

Contributor guide

Research direction
Compare the current matches() method in PrefixRouteEntryImpl with the version before commit 7ea52d5e. Trace how query parameters are handled in the match logic.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30