envoyproxy/envoy

protobuf: upstream_bind_config is a core.v3.BindConfig instead of an UpsteamBindConfig

Open

#15,516 opened on Mar 16, 2021

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/configurationbughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Description: I'm not sure if it's just "misspelt" or it has to be like this, but cluster.upstream_bind_config is a core.v3.BindConfig. I think it should be a UpstreamBindConfig. This way UpstreameBindConfig message is totally unused. And using the current state does nothing.

Additional questions: How exactly should this field work? With this upsteam_bind_config field should I be able to tell envoy which port_value should it use when sending datagrams to the upstream host? I mean we want to control the port value from our service gets its datagrams. Instead of letting envoy open a socket from a random port, we want to tell which specific port to use when connecting to an upstream host. Is it possible?

Contributor guide

Research direction
Inspect the protobuf definitions to confirm the type mismatch and update the field type.
Tech stack
cpp
Domain
backendapinetworking
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
ProtobufC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40