envoyproxy/envoy

AsyncClientFactory potentially calls ClusterManager::clusters() outside main thread

Open

#15,458 opened on Mar 12, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/cluster_managerbughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Title: AsyncClientFactory potentially calls ClusterManager::clusters() outside main thread

Description: An example of this is grpc access logger.

Another example is a filter implementation similar to ext_authz which does not skip static cluster checks (none exist in the open source codebase that I can find).

Repro steps: n/a

Admin and Stats Output: n/a

Config: n/a

Logs: see comment

Call Stack: n/a

related: #15447 #15227 #15449

Contributor guide

Research direction
Examine the grpc access logger and ext authz config to verify that ClusterManager::clusters() is called outside the main thread. Look for missing thread check assertions.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40