envoyproxy/envoy

AsyncClientFactory getThreadLocalCluster failure under validation_server

Open

#15,447 opened on Mar 11, 2021

View on GitHub
 (9 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/grpcbughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

We're seeing an issue validating our grpc access logging config

[external/envoy/source/server/config_validation/server.cc:60] error initializing configuration 'generated/config/envoy_canary.yaml': Unknown gRPC client cluster 'grpceventsink'

I think these lines should be using the helper ClusterInfoMaps.getCluster() instead of iterating the map manually.

https://github.com/envoyproxy/envoy/blob/e20957c011b11a4f9f935ec7556ed89d1d8c22d7/source/common/grpc/async_client_manager_impl.cc#L41-L42

Contributor guide

Research direction
Reproduce the error with a configuration using gRPC access log. Look at the code in async client manager impl.cc. Replace the manual iteration with ClusterInfoMaps.getCluster() to resolve the unknown cluster error.
Tech stack
cppgrpc
Domain
backendinfrastructurenetworking
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitBazel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75