envoyproxy/envoy

Make use of match tree in HCM route table

Open

#15,409 opened on Mar 10, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/httparea/matchinghelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

There's a few different ways of implementing this, but the most likely one seems to be to oneof it with the existing route table implementation. There are some challenges here due to existing couplings between the route table and filter APIs, e.g.

virtual Router::RouteConstSharedPtr route(const Router::RouteCallback& cb) PURE;

, but if we can skip supporting this for the new match tree this might be relatively easy.

One open question would be to see if we want to retain the idea of virtual hosts when using the match tree since we can express the :authority lookup within the match tree.

Contributor guide

Research direction
Investigate the coupling between the route table and filter APIs, and explore how to introduce a match tree variant using a oneof approach. Assess whether virtual hosts can be retained.
Tech stack
cpp
Domain
backendnetworking
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Envoy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40