envoyproxy/envoy

Unify URL parsing with GoogleURL

Open

#15,290 opened on Mar 3, 2021

View on GitHub
 (1 comment) (1 reaction) (1 assignee)C++ (5,373 forks)batch import
area/httparea/securityhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Two concerns:

  • llhttp (http-parser replacement) does not have a URL parser: https://github.com/nodejs/llhttp/issues/7. Derek brought up this concern in that issue.
  • The fewer different URL parsing stuff we have, the better.

Envoy uses http_parser_url to split the URL into pieces.

We should replace this with GoogleURL, which does URL parsing (https://chromium.googlesource.com/chromium/src/+/master/url#parsing). See https://chromium.googlesource.com/chromium/src/+/master/url/gurl.h#340

Related Issues: https://github.com/envoyproxy/envoy/issues/5155 https://github.com/envoyproxy/envoy/issues/6588

Can we bring back https://github.com/envoyproxy/envoy/pull/11670?

cc @derekargueta @dio @envoyproxy/security-team

Contributor guide

Research direction
Identify all usages of http parser url in the codebase, understand the GoogleURL API, and replace each usage accordingly. Ensure tests pass.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitCMake
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40