Router: Audit ASSERTs · envoyproxy/envoy

(2 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import

area/securityhelp wanted

Repository metrics

Stars: (27,997 stars)
PR merge metrics: (PR metrics pending)

Description

This issue describes a scan of ASSERTs in the router filter and recommendations to change some: https://gist.github.com/asraa/859a41a8f5f252d35da58c9ef7502230

Those marked with a verdict have been audited or unknown if they need a pair of eyes.

Change 1 refactorable call https://github.com/envoyproxy/envoy/blob/488973532ac72f56473bd2b6f770f0a011bf14a1/source/common/router/router.cc#L276 add check for scheme headers during filter processing https://github.com/envoyproxy/envoy/blob/488973532ac72f56473bd2b6f770f0a011bf14a1/source/common/router/router.cc#L566
Audit
- https://github.com/envoyproxy/envoy/blob/488973532ac72f56473bd2b6f770f0a011bf14a1/source/common/router/router.cc#L653

Contributor guide

Research direction: Examine the ASSERT statements in the router filter at the linked lines, determine if they are correct or need changes, and implement the recommended changes.
Tech stack: cpp
Domain: backendinfrastructure
Issue type: Refactor
Difficulty: 3
Estimated time: 1-2 days
Activity status: Active
Clarity: Clear
Prerequisites: C++Envoy internals
Newbie friendliness: 40