envoyproxy/envoy

Router: Audit ASSERTs

Open

#14,961 opened on Feb 5, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/securityhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

This issue describes a scan of ASSERTs in the router filter and recommendations to change some: https://gist.github.com/asraa/859a41a8f5f252d35da58c9ef7502230

Those marked with a verdict have been audited or unknown if they need a pair of eyes.

Contributor guide

Research direction
Examine the ASSERT statements in the router filter at the linked lines, determine if they are correct or need changes, and implement the recommended changes.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Envoy internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40