envoyproxy/envoy

SkyWalking tracer extension header support

Open

#14,933 opened on Feb 4, 2021

View on GitHub
 (0 comments) (1 reaction) (0 assignees)C++ (5,373 forks)batch import
area/tracingenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

In current implementation, it can't accept and use context packed on sw8-x header. This feature is already supported on cpp2sky, then just to extract propagated header and use them.

https://github.com/envoyproxy/envoy/blob/main/source/extensions/tracers/skywalking/skywalking_tracer_impl.cc#L53 https://github.com/SkyAPM/cpp2sky/blob/main/source/propagation_impl.h#L55-L63 https://github.com/apache/skywalking/blob/08781b41a8255bcceebb3287364c81745a04bec6/docs/en/protocols/Skywalking-Cross-Process-Propagation-Headers-Protocol-v3.md#extension-header-item

Contributor guide

Research direction
Implement support for the sw8 x extension header in the SkyWalking tracer by extracting context from the header and propagating it similar to cpp2sky implementation. Refer to the provided links for detailed logic.
Tech stack
cpp
Domain
observability
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65