envoyproxy/envoy

Remove unused methods and exceptions from JsonObject

Open

#14,893 opened on Feb 1, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
help wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

  1. Remove instance of loadFromString in header formatter and replace with protobuf . https://github.com/envoyproxy/envoy/blob/e073b325890542a3ce3bbc4eefb89a09f390f27e/source/common/router/header_formatter.cc#L61

  2. Remove unused methods and the unsafe code that can throw exceptions such as the get[Type] methods that don't have defaults. https://github.com/envoyproxy/envoy/blob/0d5b470097d5e3645759e43414db8a7104aafb2e/include/envoy/json/json_object.h#L114

Follow-up to https://github.com/envoyproxy/envoy/pull/14467

Contributor guide

Research direction
Remove the loadFromString method from header formatter.cc and replace it with protobuf. Then remove the get[Type] methods from json object.h that can throw exceptions.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80